Add missing code fixers for MA0088-MA0137#1072
Merged
Merged
Conversation
Implement missing code fix providers and tests for MA0088, MA0090, MA0099, MA0105, MA0106, MA0112, MA0127, MA0129, and MA0131. MA0137 already had an existing fixer and is covered by targeted tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Address CA1859, IDE0060, and IDE1006 violations in new code-fixer implementation so publish/build_and_test jobs compile cleanly across matrix versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Synchronize rule docs and docs index with newly added code fix providers so check_documentation passes in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update DocumentationGenerator to use FullPath.TryFindGitRepositoryRoot and upgrade Meziantou.Framework.FullPath to 1.1.18. This supports worktree repositories and allows documentation generation to run without custom git-folder logic. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add MA0099 enum-zero fallback cast fix/test, tighten MA0129 task-disposable fix applicability and tests, and update MA0127 to offer Ordinal + OrdinalIgnoreCase fixes while making the rule hidden and enabled by default. Regenerate docs and default editorconfig. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Mar 30, 2026
From the description, I don't see a docs update after this? |
This was referenced Mar 31, 2026
Closed
Closed
This was referenced May 7, 2026
Closed
Closed
Closed
This was referenced May 15, 2026
Closed
Open
Closed
Closed
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several analyzer rules had diagnostics but no corresponding code fixes, which made remediation slower and less discoverable for users relying on "Fix all" workflows.
What changed
This PR adds/extends code-fix support for the requested rules:
MA0088(OptionalParametersAttributeFixer)MA0090(RemoveEmptyBlockFixer)MA0099(DoNotUseZeroToInitializeAnEnumValueFixer)MA0105/MA0106(AvoidClosureWhenUsingConcurrentDictionaryFixer)MA0127(UseStringEqualsInsteadOfIsPatternFixer)MA0129(TaskInUsingFixer)MA0131(ThrowIfNullWithNonNullableInstanceFixer)OptimizeLinqUsageFixerto supportMA0112(UseCountInsteadOfAny).MA0137already had an existing fixer (MethodsReturningAnAwaitableTypeMustHaveTheAsyncSuffixFixer), and coverage was validated.Tests and validation
dotnet build -v:q✅Notes
dotnet run --project src/DocumentationGeneratorfails in this worktree environment withCannot find the current git folder(worktree.gitfile vs directory expectation), so documentation regeneration could not be completed here.